Delete builddefines.h

Nothing was left in it but the include of profiler.h, and 132 translation units
were including it for that alone. Fifteen files were leaning on profiler.h to
drag in <set>, <vector> and <ostream> for them; those now include what they use.

This is the commit that moves line numbers. Removing an include line shifts
__LINE__ by one for everything below it, and __LINE__ is an immediate operand in
every Assert() and DebugMsg() call, so the four game executables differ from
their predecessors by roughly a thousand 32-bit constants each. Every one of
those is accounted for: each is a single immediate that moved by -1 where the
builddefines.h include went away, or +1 where a <set>/<vector> include was
added. Nothing else in .text, .rdata or .data moves, no object file's section
sizes change, and symbolize_crash and Ja2Export stay bit-identical.

The one non-immediate difference is that the 24 Editor translation units of the
non-editor apps stop emitting __Avx2WmemEnabledWeakValue, a 4-byte weak COMDAT
they only ever instantiated through profiler.h's <vector>. It is a UCRT weak
default that other translation units still provide.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Marco Antonio J. Costa
2026-08-22 01:07:26 -03:00
committed by majcosta
co-authored by Claude Opus 5
parent 0a5ce33c08
commit 00fb898600
147 changed files with 16 additions and 143 deletions
-1
View File
@@ -1,6 +1,5 @@
//Strategic AI Viewer
#include "builddefines.h"
#include <stdio.h>
#include "types.h"
#include "english.h"
+1
View File
@@ -3,6 +3,7 @@
* @author Flugente (bears-pit.com)
*/
#include <set>
#include <math.h>
#include "ASD.h"
#include "strategic.h"
+2
View File
@@ -6,6 +6,8 @@
* @author Flugente (bears-pit.com)
*/
#include <vector>
#include <set>
#include "types.h"
/** Flugente: Arulco special division decision code
-1
View File
@@ -1,4 +1,3 @@
#include "builddefines.h"
#include <stdio.h>
#include "types.h"
#include "Auto Resolve.h"
+1
View File
@@ -1,6 +1,7 @@
#ifndef __CAMPAIGN_TYPES_H
#define __CAMPAIGN_TYPES_H
#include <vector>
#include "types.h"
#include "DEBUG.H"
#include <map>
-1
View File
@@ -6,7 +6,6 @@
// XML_FacilityTypes.cpp for the reading XML functions.
//////////////////////////////////////////////////////////////////
#include "builddefines.h"
#include "Campaign Types.h"
#include "Facilities.h"
+1
View File
@@ -1,6 +1,7 @@
#ifndef __GAME_EVENT_HOOK_H
#define __GAME_EVENT_HOOK_H
#include <vector>
#include "types.h"
enum
-1
View File
@@ -1,4 +1,3 @@
#include "builddefines.h"
#include <stdio.h>
#include "types.h"
#include "Game Events.h"
-1
View File
@@ -1,5 +1,4 @@
#ifdef JA2UB
#include "builddefines.h"
#include "strategicmap.h"
#include "strategic.h"
+1
View File
@@ -1,3 +1,4 @@
#include <set>
#include "Font.h"
#include "Font Control.h"
#include "mapscreen.h"
-1
View File
@@ -1,4 +1,3 @@
#include "builddefines.h"
#include "types.h"
#include "Merc Contract.h"
-1
View File
@@ -1,4 +1,3 @@
#include "builddefines.h"
#include <stdio.h>
#include "PreBattle Interface.h"
#include "Button System.h"
-1
View File
@@ -1,4 +1,3 @@
#include "builddefines.h"
#include "types.h"
#include "Quest Debug System.h"
-1
View File
@@ -1,7 +1,6 @@
#ifndef __SCHEDULING_H
#define __SCHEDULING_H
#include "builddefines.h"
#include "Soldier Init List.h"
//Merc scheduling actions
-1
View File
@@ -1,4 +1,3 @@
#include "builddefines.h"
#include <stdio.h>
#include "types.h"
#include "Strategic Movement.h"
-1
View File
@@ -1,4 +1,3 @@
#include "builddefines.h"
#include <stdlib.h>
#include "Strategic Movement.h"
#include "MemMan.h"
-1
View File
@@ -1,4 +1,3 @@
#include "builddefines.h"
#include "Strategic Town Loyalty.h"
#include "strategicmap.h"
+1
View File
@@ -18,6 +18,7 @@ Transport group compositions will vary based on the player's progress, how many
and the difficulty of the game.
*/
#include <set>
#include "Strategic Transport Groups.h"
#include "ASD.h"
-1
View File
@@ -1,4 +1,3 @@
#include "builddefines.h"
#include "Town Militia.h"
#include "Militia Control.h"
-1
View File
@@ -1,4 +1,3 @@
#include "builddefines.h"
#include <stdio.h>
#include "XML.h"
-1
View File
@@ -1,4 +1,3 @@
#include "builddefines.h"
#include <stdio.h>
#include "XML.h"
#include "expat.h"
-1
View File
@@ -1,4 +1,3 @@
#include "builddefines.h"
#include <stdio.h>
#include "XML.h"
#include "expat.h"
-1
View File
@@ -1,4 +1,3 @@
#include "builddefines.h"
#include <stdio.h>
#include "XML.h"
#include "expat.h"
-1
View File
@@ -1,4 +1,3 @@
#include "builddefines.h"
#include <stdio.h>
#include "XML.h"
#include "expat.h"
-1
View File
@@ -8,7 +8,6 @@
//////////////////////////////////////////////////////////////
#include "builddefines.h"
#include <stdio.h>
#include "XML.h"
#include "expat.h"
-1
View File
@@ -1,4 +1,3 @@
#include "builddefines.h"
#include "strategicmap.h"
#include "strategic.h"