From 1bead3a0fe8e49a490c6ba56b447ecddb1703cf7 Mon Sep 17 00:00:00 2001 From: Asdow <20314541+Asdow@users.noreply.github.com> Date: Thu, 22 Jan 2026 00:27:53 +0200 Subject: [PATCH] Improve readability --- TacticalAI/DecideAction.cpp | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/TacticalAI/DecideAction.cpp b/TacticalAI/DecideAction.cpp index 888e3666..579dbaaa 100644 --- a/TacticalAI/DecideAction.cpp +++ b/TacticalAI/DecideAction.cpp @@ -18480,16 +18480,18 @@ INT8 DecideActionRedSoldier(SOLDIERTYPE* pSoldier) if (BestThrow.ubPossible) { DebugAI(AI_MSG_INFO, pSoldier, String("throw possible"), gLogDecideActionRed); + + const auto item = pSoldier->inv[BestThrow.bWeaponIn].usItem; + // sevenfm: allow using mortars, grenade launchers, flares and grenades in RED state - if (ItemIsMortar(pSoldier->inv[BestThrow.bWeaponIn].usItem) || - //Item[pSoldier->inv[ BestThrow.bWeaponIn ].usItem].cannon || - ItemIsRocketLauncher(pSoldier->inv[BestThrow.bWeaponIn].usItem) || - ItemIsGrenadeLauncher(pSoldier->inv[BestThrow.bWeaponIn].usItem) || - ItemIsFlare(pSoldier->inv[BestThrow.bWeaponIn].usItem) || - Item[pSoldier->inv[BestThrow.bWeaponIn].usItem].usItemClass & IC_GRENADE) + if (ItemIsMortar(item) || + ItemIsRocketLauncher(item) || + ItemIsGrenadeLauncher(item) || + ItemIsFlare(item) || + Item[item].usItemClass & IC_GRENADE) { // if firing mortar make sure we have room - if (ItemIsMortar(pSoldier->inv[BestThrow.bWeaponIn].usItem)) + if (ItemIsMortar(item)) { DebugAI(AI_MSG_INFO, pSoldier, String("using mortar, check room to deploy"), gLogDecideActionRed); ubOpponentDir = AIDirection(pSoldier->sGridNo, BestThrow.sTarget);