Fix: bad radar/overhead map colours for creature team.

For more info, see http://thepit.ja-galaxy-forum.com/index.php?t=msg&th=22776&goto=353150&#msg_353150

git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8553 3b4a5df2-a311-0410-b5c6-a8a6f20db521

TileEngine/Radar Screen.cpp

@@ -607,8 +607,7 @@ void RenderRadarScreen( )
 				// Add starting relative to interface
 				sXSoldRadar += RADAR_WINDOW_TM_X;
 				sYSoldRadar += gsRadarY;
-
-
+				
 				if(gbPixelDepth==16)
 				{
 					// DB Need to add a radar color for 8-bit
@@ -647,6 +646,14 @@ void RenderRadarScreen( )
 								usLineColor = Get16BPPColor( FROMRGB( 0, 0, 255 ) );
 						}
 
+						// Flugente 18-04-15: observed an odd bug: if we play with a release build and see a creature for the first time, their overhead/radar map pins do not have the correct colour.
+						// Bizarrely enough, the issue seems dependent on the colour value (pink, RGB: 255/0/255) itself.
+						// Saving and reloading solves the issue, but I am not sure why. As a fix we now use a slightly dampened pink.
+						if ( pSoldier->bTeam == CREATURE_TEAM )
+						{
+							usLineColor = Get16BPPColor( FROMRGB( 247, 0, 247 ) );
+						}
+
 						// Flugente: if we are a (still covert) enemy assassin, colour us like militia, so that the player wont notice us
 						if ( pSoldier->usSoldierFlagMask & SOLDIER_ASSASSIN && pSoldier->usSoldierFlagMask & SOLDIER_COVERT_SOLDIER )
 							usLineColor = Get16BPPColor( gTacticalStatus.Team[ MILITIA_TEAM ].RadarColor );
@@ -675,9 +682,9 @@ void RenderRadarScreen( )
 			}
 		}
 	}
+
 	UnLockVideoSurface( FRAME_BUFFER );
-
-
+	
 	if( ( guiTacticalInterfaceFlags & INTERFACE_MAPSCREEN ) && ( fShowMapInventoryPool == TRUE ) )
 	{
 		// CHRISL:
@@ -685,13 +692,8 @@ void RenderRadarScreen( )
 										gsRadarX + RADAR_WINDOW_WIDTH,
 										gsRadarY + RADAR_WINDOW_HEIGHT );
 	}
-
-	return;
-
-
 }
 
-
 void AdjustWorldCenterFromRadarCoords( INT16 sRadarX, INT16 sRadarY )
 {
 	INT16 sScreenX, sScreenY;