From 2c6202334e90a6c8959a7bb3dce77e2b6118849b Mon Sep 17 00:00:00 2001 From: "Marco Antonio J. Costa" Date: Wed, 22 Jul 2026 14:26:30 -0300 Subject: [PATCH] say what size the pixelation pattern compare reads The pattern compare in Blt16BPPBufferPixelateRectWithColor gives neither operand a size: a memory reference with no register to take the width from, against an untyped zero. MSVC picks a byte, which is right -- Pattern is UINT8[8][8], and every other access to it in the block goes through al -- but the source never says so, and clang-cl refuses to guess. Naming the size changes nothing. cl emits 80 3C 1E 00 before and after. --- sgp/vobject_blitters.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sgp/vobject_blitters.cpp b/sgp/vobject_blitters.cpp index 6637db9ef..5556d2ed9 100644 --- a/sgp/vobject_blitters.cpp +++ b/sgp/vobject_blitters.cpp @@ -9790,7 +9790,7 @@ BlitNewLine: mov ecx, width BlitLine: - cmp [esi+ebx], 0 + cmp byte ptr [esi+ebx], 0 // Pattern is UINT8[8][8] je BlitLine2 mov [edi], ax