From 3a9d6d65e4518c30d4bba18ec17b0fb96ca95c93 Mon Sep 17 00:00:00 2001
From: Sevenfm <Sevenfm@3b4a5df2-a311-0410-b5c6-a8a6f20db521>
Date: Fri, 11 Feb 2022 11:22:33 +0000
Subject: [PATCH] Shift+T: only allow item transformation if item is corpse or
 resulting item is of the same item class, also check it's not transformation
 into same item.

git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@9296 3b4a5df2-a311-0410-b5c6-a8a6f20db521
---
 Tactical/Turn Based Input.cpp | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/Tactical/Turn Based Input.cpp b/Tactical/Turn Based Input.cpp
index 94a1f6a91..47cd8188e 100644
--- a/Tactical/Turn Based Input.cpp	
+++ b/Tactical/Turn Based Input.cpp	
@@ -370,7 +370,7 @@ void HandleTacticalTransformItem( void );
 void HandleTacticalTransformFlashlight(void);
 void HandleTacticalTransformLaser(void);
 void HandleTacticalTransformScope(void);
-BOOLEAN FindTransformation( UINT16 usItem, TransformInfoStruct **pTransformation );
+BOOLEAN FindTransformation(UINT16 usItem, TransformInfoStruct **pTransformation, BOOLEAN fTactical = FALSE);
 BOOLEAN FindLaserTransformation(UINT16 usItem, TransformInfoStruct **pTransformation);
 BOOLEAN FindScopeTransformation(UINT16 usItem, TransformInfoStruct **pTransformation);
 
@@ -8752,7 +8752,7 @@ void HandleTacticalTransformItem(void)
 
 	usItem = pSoldier->inv[HANDPOS].usItem;
 
-	if (FindTransformation(usItem, &pTransformation))
+	if (FindTransformation(usItem, &pTransformation, TRUE))
 	{
 		if (pTransformation->usAPCost > 0 && gTacticalStatus.uiFlags & INCOMBAT && gTacticalStatus.uiFlags & TURNBASED)
 			ScreenMsg(FONT_MCOLOR_LTYELLOW, MSG_INTERFACE, L"%s (%d AP)", pTransformation->szMenuRowText, pTransformation->usAPCost);
@@ -8772,7 +8772,7 @@ void HandleTacticalTransformItem(void)
 	}
 }
 
-BOOLEAN FindTransformation( UINT16 usItem, TransformInfoStruct **pTransformation )
+BOOLEAN FindTransformation(UINT16 usItem, TransformInfoStruct **pTransformation, BOOLEAN fTactical)
 {
 	// find transformation
 	for ( UINT32 x = 0; x < MAXITEMS + 1; ++x )
@@ -8781,7 +8781,10 @@ BOOLEAN FindTransformation( UINT16 usItem, TransformInfoStruct **pTransformation
 		{
 			break;
 		}
-		if ( Transform[x].usItem == usItem )
+		if (Transform[x].usItem == usItem &&
+			(!fTactical ||
+			HasItemFlag(usItem, CORPSE) ||
+			Transform[x].usResult[0] != usItem && Item[Transform[x].usResult[0]].usItemClass == Item[usItem].usItemClass))
 		{
 			*pTransformation = &Transform[x];
 			return TRUE;