1dot13/source
1
0
Fork 0
mirror of https://github.com/1dot13/source.git synced 2026-08-05 14:00:23 +02:00
Code Issues Packages Projects Releases Wiki Activity

delete the stack tracer that never captured a frame

Browse Source 
ENABLE_STACK_TRACE has been 0 for as long as the file has been here, so
StackTrace's constructor captured nothing and every line it ever wrote to
stack_trace.log was a bare message with an empty frame list behind it. The
DbgHelp singleton underneath it resolved symbols for that empty list, and
the game linked dbghelp.lib to do it.

The crash reports cover what this was meant to cover, and the VFS errors
that were its only real content are already in vfs.log and game_log.log.
Drop the tracer, the log, and the dbghelp dependency.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Marco Antonio J. Costa
2026-07-31 16:51:06 -03:00
committed by majcosta
co-authored by Claude Opus 5
parent 40bf6326c8
commit 7624daa904
7 changed files with 5 additions and 298 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sgp/sgp.cpp
+3 -13
View File
@@ -636,27 +636,18 @@ static vfs::String getGameID()
class VfsLogAdapter : public vfs::Aspects::ILogger
{
public:
VfsLogAdapter(sgp::Logger_ID ID, bool stacktrace = false) : _id(ID), _trace(stacktrace) {};
VfsLogAdapter(sgp::Logger_ID ID) : _id(ID) {};
virtual void Msg(const wchar_t* msg)
{
SGP_LOG(_id, msg);
if(_trace)
{
sgp::dumpStackTrace(msg);
}
}
virtual void Msg(const char* msg)
{
SGP_LOG(_id, msg);
if(_trace)
{
sgp::dumpStackTrace(msg);
}
}
private:
sgp::Logger_ID _id;
bool _trace;
};
//#include <vfs/Aspects/vfs_synchronization.h>
@@ -751,10 +742,9 @@ int PASCAL WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR pCommandL
sgp::Logger::instance().connectFile(VFS_LOG, L"vfs.log", false, sgp::Logger::FLUSH_ON_DELETE);
VfsLogAdapter* vfslog = new VfsLogAdapter(VFS_LOG, false);
VfsLogAdapter* vfslog_error = new VfsLogAdapter(VFS_LOG, true);
VfsLogAdapter* vfslog = new VfsLogAdapter(VFS_LOG);
vfs::Aspects::setLogger(vfslog, vfslog, vfslog_error, NULL /* vfslog */);
vfs::Aspects::setLogger(vfslog, vfslog, vfslog, NULL /* vfslog */);
// Make sure that only one instance of this application is running at once
// // Look for prev instance by searching for the window