From 7e55488b40835079989366790918067a0559d990 Mon Sep 17 00:00:00 2001 From: rftrdev <102184004+rftrdev@users.noreply.github.com> Date: Tue, 18 Oct 2022 17:27:05 -0700 Subject: [PATCH] Clean up some todos --- Strategic/Rebel Command.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/Strategic/Rebel Command.cpp b/Strategic/Rebel Command.cpp index 381be3c9..686b04b3 100644 --- a/Strategic/Rebel Command.cpp +++ b/Strategic/Rebel Command.cpp @@ -2118,7 +2118,6 @@ BOOLEAN SetupMissionAgentBox(UINT16 x, UINT16 y, INT8 index) if (agentIndex[index] < 0) agentIndex[index] = static_cast(mercs.size()); else if (agentIndex[index] > static_cast(mercs.size())) agentIndex[index] = 0; - // rftr todo: handle RCAM_NONE (ie, mission prep in progress!) if (rebelCommandSaveInfo.availableMissions[index] == RCAM_NONE) { // we shouldn't even reach this point, but leaving this here for safety @@ -2531,7 +2530,6 @@ void RenderMissionOverview() } else { - // rftr todo: run through active mission list (missionMap) and show a one-line description for each. std::vector evt1Strings; std::vector evt2Strings; std::vector> missions = GetAllStrategicEventsOfType(EVENT_REBELCOMMAND); @@ -2591,7 +2589,6 @@ void StartMission(INT8 index) return; } - // todo do something with agentIndex[index] and missionIndex[index] (rebelCommandSaveInfo.availableMissions[index]) // confirmation popup std::vector mercs; for (UINT8 i = gTacticalStatus.Team[OUR_TEAM].bFirstID; i <= gTacticalStatus.Team[OUR_TEAM].bLastID; ++i) @@ -3669,7 +3666,6 @@ void DailyUpdate() } // update missions - // rftr todo: test me if (GetWorldDay() % gRebelCommandSettings.iMissionRefreshTimeDays == 0) { std::unordered_set validMissions; @@ -4278,7 +4274,6 @@ INT16 GetAdditionalDeployRange(const UINT8 insertionCode) { range = gRebelCommandSettings.iDeepDeploymentRangeNS; - // rftr todo: bitmagic to get bonus range switch (evt.extraBits) { case MissionHelpers::DEEP_DEPLOYMENT_RANGE_BONUS_COVERT: range += gRebelCommandSettings.iDeepDeploymentRangeNS_Bonus_Covert; break; @@ -4411,7 +4406,6 @@ FLOAT GetStrategicDecisionSpeedModifier() void HandleStrategicEvent(const UINT32 eventParam) { // this handles the transition from "mission prep" (first event) to "mission active" (second event), which happens 24 hours after the player clicks on "start mission" - // rftr todo: update agent mission bitmask MissionFirstEvent evt1; MissionSecondEvent evt2; DeserialiseMissionFirstEvent(eventParam, evt1); @@ -4498,7 +4492,6 @@ void HandleStrategicEvent(const UINT32 eventParam) } } - // rftr todo: tell the player that the mission has started. popupbox or screenmsg? missionMap.insert(std::make_pair(mission, activatedMissionParam)); swprintf(msgBoxText, L"Mission prep success! %s", szRebelCommandAgentMissionsText[evt1.missionId * 2]); swprintf(screenMsgText, L"Mission \"%s\" is now in effect.", szRebelCommandAgentMissionsText[evt1.missionId * 2]); @@ -4507,7 +4500,6 @@ void HandleStrategicEvent(const UINT32 eventParam) } else { - // rftr todo: tell the player that the mission prep failed. some popup box blurb or somesuch. if (!evt1.sentGenericRebelAgent && foundMerc) { for (UINT8 i = gTacticalStatus.Team[OUR_TEAM].bFirstID; i <= gTacticalStatus.Team[OUR_TEAM].bLastID; ++i)