mirror of
https://github.com/1dot13/source.git
synced 2026-08-19 14:20:30 +02:00
Report module names, not the paths they were loaded from
The module table is what makes a report symbolizable, but a full path also carries the player's Windows account name and wherever they keep the game, and the report leaves their machine. Symbolizing only ever matched on module name and base — symbolize_crash already ran every path through baseName() before printing it — so the directory was read by nothing. Say so in the consent prompt too. "No personal information" was not true of a table full of paths, and is only worth claiming if it holds. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
committed by
majcosta
co-authored by
Claude Opus 5
parent
3794e3a274
commit
90f5bff69b
@@ -148,7 +148,9 @@ void processCrashTelemetry(const wchar_t* url) {
|
||||
if (consent < 0) { // first run: ask once, remember the answer
|
||||
int r = MessageBoxW(NULL,
|
||||
L"This build can send crash reports to the developers to help fix bugs.\n"
|
||||
L"A report contains only technical crash data \x2014 no personal information.\n\n"
|
||||
L"A report contains where the game crashed, the names of the loaded\n"
|
||||
L"modules, and the HANDLE from your Ja2.ini if you set one. No file\n"
|
||||
L"paths, no save games, nothing else about your machine.\n\n"
|
||||
L"Send crash reports automatically?",
|
||||
L"Jagged Alliance 2 v1.13 \x2014 Crash Reporting",
|
||||
MB_YESNO | MB_ICONQUESTION);
|
||||
|
||||
Reference in New Issue
Block a user