From e1acf181df309e2e7626e28718b94845068770ae Mon Sep 17 00:00:00 2001 From: Asdow <20314541+Asdow@users.noreply.github.com> Date: Mon, 29 Sep 2025 11:53:31 +0300 Subject: [PATCH] Add FIXME --- Strategic/LuaInitNPCs.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Strategic/LuaInitNPCs.cpp b/Strategic/LuaInitNPCs.cpp index 170cffe61..4992a7536 100644 --- a/Strategic/LuaInitNPCs.cpp +++ b/Strategic/LuaInitNPCs.cpp @@ -2877,7 +2877,10 @@ BOOLEAN LuaIDScripts(UINT8 Init, UINT8 ubTargetNPC, UINT16 usActionCode, UINT8 u return true; } - +// FIXME: Right now this function returns the very first pSoldier from CIV_TEAM that is active and in sector +// Neither one of the function arguments are used inside the function and the only place where this is called +// makes it look like it *is* supposed to match against specific profile *and* restrict the search to player mercs. +// That last part makes no sense since player mercs are part of OUR_TEAM SOLDIERTYPE* FindSoldierByProfileID2(UINT8 ubProfileID, BOOLEAN fPlayerMercsOnly) { SoldierID soldier = gTacticalStatus.Team[CIV_TEAM].bFirstID;