1dot13/source
1
0
Fork 0
mirror of https://github.com/1dot13/source.git synced 2026-09-16 14:47:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

remove stray 'typename' before non-qualified names

Browse Source 
'typename' disambiguates a qualified dependent name, telling the
compiler that something like T::iterator names a type rather than a
value. Before a plain identifier there is nothing to disambiguate: P1
is already a type, and so is PopupIndex.

The grammar wants a qualified name after the keyword, so clang reports
"expected a qualified name after 'typename'", drops the keyword and
carries on -- 15175 times, since the offending declarations sit in
widely included headers. MSVC accepts them without a word.

Semantics do not change. Both compilers already ignored the keyword,
so the partial specialisations matched before this and match after it.

The diagnostic belongs to no -W group and therefore cannot be switched
off with -Wno-, which makes deleting the tokens the only way to quiet
it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Marco Antonio J. Costa
2026-07-27 13:05:23 -03:00
committed by majcosta
co-authored by Claude Opus 5
parent b6c79dbead
commit fc1c1dfe77
3 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Utils/popup_class.h
+1 -1
View File
@@ -44,7 +44,7 @@
UINT32 classId;
} PopupIndex ;
extern std::vector<typename PopupIndex> gPopupRegionIndex;
extern std::vector<PopupIndex> gPopupRegionIndex;
extern std::vector<POPUP*> gPopupIndex;
extern UINT32 gPopupRegionIndexCounter;