mirror of
https://github.com/1dot13/source.git
synced 2026-07-29 13:52:17 +02:00
58e00e0d66
The other half of the feature, and the half that decides whether a player's report survives: the endpoint CRASH_TELEMETRY_URL points at. It takes the POST from processCrashTelemetry and forwards the report to a Discord webhook as a file attachment. It stores nothing -- a report is only worth reading next to the PDB it was built against, and that never leaves a developer's machine, so there is nothing for a bucket to do here that the channel we already read bug reports in does not do better. That also keeps the whole thing inside the Workers free tier, where the 10 ms budget is CPU, not wall clock, and waiting on Discord is not metered. In the repo rather than in someone's home directory because the status codes are a contract with the client and the two have to be changed together. reportIsSettled() in sgp/crash_telemetry.cpp deletes the player's copy on 2xx and on 400/413/415 and keeps it on everything else, so a settling 4xx returned for a failure on our side silently destroys the report. Every failure path here is therefore a 503, each naming its own cause in wrangler's console, and the one 4xx that is safe -- 429, which the client does not settle -- is the one the rate limiter returns. That rate limiter is a binding with a .limit() call, not a dashboard rule: WAF rate limiting rules need a zone and a workers.dev subdomain is not one. Per-IP, 50 a minute, which has to clear kMaxUploadsPerRun (20) in the client or a player draining a backlog throttles themselves. It is checked before the body is read. A report is attacker-controlled text arriving at a public, unauthenticated endpoint whose URL ships in every player's Ja2.ini, so the summary line strips markdown from the player handle and the payload sets allowed_mentions to nothing. The size cap and the "*** CRASH" check keep drive-by scanners out; anything determined gets through, and the blast radius is a message we delete. test.mjs covers the whole contract against a stubbed fetch, no network and no webhook needed. DISCORD_WEBHOOK is a secret and lives nowhere in this tree; .dev.vars, which holds a live one for local development, is gitignored. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
63 lines
2.3 KiB
JavaScript
63 lines
2.3 KiB
JavaScript
// node test.mjs — exercises the status-code contract the client depends on.
|
|
import assert from "node:assert";
|
|
import worker from "./worker.js";
|
|
|
|
const REPORT = `
|
|
*** CRASH code=C0000005 eip=0071D5A0 esp=202BF99C ebp=202BFA18 ***
|
|
time 2026-07-26 10:41:02 UTC
|
|
build 6a941c06
|
|
handle @marco*evil
|
|
access violation: read from 00000002
|
|
[0] 0071D5A0
|
|
[1] 006BE7DE
|
|
`;
|
|
|
|
let sent = null; // what we handed Discord on the last call
|
|
let upstream = () => new Response(null, { status: 204 });
|
|
globalThis.fetch = async (url, init) => { sent = init; return upstream(); };
|
|
|
|
let throttled = false;
|
|
const ENV = {
|
|
DISCORD_WEBHOOK: "https://discord.test/hook",
|
|
UPLOAD_LIMITER: { limit: async () => ({ success: !throttled }) },
|
|
};
|
|
|
|
const post = (body, env = ENV) =>
|
|
worker.fetch(new Request("https://x/", { method: "POST", body }), env);
|
|
|
|
// happy path
|
|
let r = await post(REPORT);
|
|
assert.equal(r.status, 204);
|
|
const content = JSON.parse(sent.body.get("payload_json")).content;
|
|
assert.match(content, /C0000005/);
|
|
assert.match(content, /read from 00000002/);
|
|
assert.match(content, /build `6a941c06`/);
|
|
assert.match(content, /marcoevil/); // markdown and @ stripped from the handle
|
|
assert.deepEqual(JSON.parse(sent.body.get("payload_json")).allowed_mentions, { parse: [] });
|
|
assert.equal(await sent.body.get("files[0]").text(), REPORT);
|
|
|
|
// junk: client should delete these, so they must be 400
|
|
assert.equal((await post("hello")).status, 400);
|
|
assert.equal((await post("x".repeat(64 * 1024 + 1))).status, 400);
|
|
|
|
// throttled: 429, and nothing reaches Discord. reportIsSettled() leaves 429
|
|
// unsettled, so the client keeps the report for next launch.
|
|
throttled = true;
|
|
sent = null;
|
|
assert.equal((await post(REPORT)).status, 429);
|
|
assert.equal(sent, null);
|
|
throttled = false;
|
|
|
|
// our failures: client must keep the report, so these must be 5xx
|
|
upstream = () => new Response(null, { status: 429 }); // Discord rate limit
|
|
assert.equal((await post(REPORT)).status, 503);
|
|
upstream = () => { throw new Error("network"); };
|
|
assert.equal((await post(REPORT)).status, 503);
|
|
upstream = () => new Response(null, { status: 204 });
|
|
assert.equal((await post(REPORT, {})).status, 503); // secret not set
|
|
|
|
// wrong method
|
|
assert.equal((await worker.fetch(new Request("https://x/"), {})).status, 405);
|
|
|
|
console.log("ok");
|