Files
source/sgp/debug_win_util.cpp
T
90f5bff69b Report module names, not the paths they were loaded from
The module table is what makes a report symbolizable, but a full path also
carries the player's Windows account name and wherever they keep the game,
and the report leaves their machine. Symbolizing only ever matched on module
name and base — symbolize_crash already ran every path through baseName()
before printing it — so the directory was read by nothing.

Say so in the consent prompt too. "No personal information" was not true of
a table full of paths, and is only worth claiming if it holds.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-07-28 10:25:47 -03:00

406 lines
15 KiB
C++

// Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#if defined(_MSC_VER)
#include "debug_util.h"
#include <windows.h>
#include <dbghelp.h>
#include <winternl.h> // PEB loader list, so the module table costs no allocation
#include <vfs/Tools/vfs_log.h>
// The arraysize(arr) macro returns the # of elements in an array arr.
// The expression is a compile-time constant, and therefore can be
// used in defining new arrays, for example. If you use arraysize on
// a pointer by mistake, you will get a compile-time error.
//
// One caveat is that arraysize() doesn't accept any array of an
// anonymous type or a type defined inside a function. In these rare
// cases, you have to use the unsafe ARRAYSIZE_UNSAFE() macro below. This is
// due to a limitation in C++'s template system. The limitation might
// eventually be removed, but it hasn't happened yet.
// This template function declaration is used in defining arraysize.
// Note that the function doesn't need an implementation, as we only
// use its type.
template <typename T, size_t N>
char (&ArraySizeHelper(T (&array)[N]))[N];
// That gcc wants both of these prototypes seems mysterious. VC, for
// its part, can't decide which to use (another mystery). Matching of
// template overloads: the final frontier.
#ifndef _MSC_VER
template <typename T, size_t N>
char (&ArraySizeHelper(const T (&array)[N]))[N];
#endif
#define arraysize(array) (sizeof(ArraySizeHelper(array)))
namespace {
// SymbolContext is a threadsafe singleton that wraps the DbgHelp Sym* family
// of functions. The Sym* family of functions may only be invoked by one
// thread at a time. SymbolContext code may access a symbol server over the
// network while holding the lock for this singleton. In the case of high
// latency, this code will adversly affect performance.
//
// There is also a known issue where this backtrace code can interact
// badly with breakpad if breakpad is invoked in a separate thread while
// we are using the Sym* functions. This is because breakpad does now
// share a lock with this function. See this related bug:
//
// http://code.google.com/p/google-breakpad/issues/detail?id=311
//
// This is a very unlikely edge case, and the current solution is to
// just ignore it.
class SymbolContext {
public:
static SymbolContext* Get() {
static SymbolContext* s_singleton = NULL;
if(!s_singleton) s_singleton = new SymbolContext();
return s_singleton;
// We use a leaky singleton because code may call this during process
// termination.
//return Singleton<SymbolContext, LeakySingletonTraits<SymbolContext> >::get();
}
// Returns the error code of a failed initialization.
DWORD init_error() const {
return init_error_;
}
// For the given trace, attempts to resolve the symbols, and output a trace
// to the ostream os. The format for each line of the backtrace is:
//
// <tab>SymbolName[0xAddress+Offset] (FileName:LineNo)
//
// This function should only be called if Init() has been called. We do not
// LOG(FATAL) here because this code is called might be triggered by a
// LOG(FATAL) itself.
void OutputTraceToStream(const std::vector<void*>& trace, sgp::Logger::LogInstance* os) {
//AutoLock lock(lock_);
for (size_t i = 0; (i < trace.size()); ++i) {
const int kMaxNameLength = 256;
DWORD_PTR frame = reinterpret_cast<DWORD_PTR>(trace[i]);
// Code adapted from MSDN example:
// http://msdn.microsoft.com/en-us/library/ms680578(VS.85).aspx
ULONG64 buffer[
(sizeof(SYMBOL_INFO) +
kMaxNameLength * sizeof(wchar_t) +
sizeof(ULONG64) - 1) /
sizeof(ULONG64)];
// Initialize symbol information retrieval structures.
DWORD64 sym_displacement = 0;
PSYMBOL_INFO symbol = reinterpret_cast<PSYMBOL_INFO>(&buffer[0]);
symbol->SizeOfStruct = sizeof(SYMBOL_INFO);
symbol->MaxNameLen = kMaxNameLength;
BOOL has_symbol = SymFromAddr(GetCurrentProcess(), frame,
&sym_displacement, symbol);
// Attempt to retrieve line number information.
DWORD line_displacement = 0;
IMAGEHLP_LINE64 line = {};
line.SizeOfStruct = sizeof(IMAGEHLP_LINE64);
BOOL has_line = SymGetLineFromAddr64(GetCurrentProcess(), frame,
&line_displacement, &line);
// Output the backtrace line.
(*os) << " ";
if (has_symbol)
{
(*os) << " [0x" << trace[i] << "+" << sym_displacement << "]\t";
(*os) << vfs::String(symbol->Name);
}
else
{
(*os) << " [0x" << trace[i] << "]\t";
// If there is no symbol information, add a spacer.
(*os) << " (No symbol)";
}
if (has_line)
{
(*os) << " - (" << line.FileName << ":" << line.LineNumber << ")";
}
(*os) << sgp::endl;
}
(*os) << sgp::endl;
}
private:
SymbolContext() : init_error_(ERROR_SUCCESS) {
// Initializes the symbols for the process.
// Defer symbol load until they're needed, use undecorated names, and
// get line numbers.
SymSetOptions(SYMOPT_DEFERRED_LOADS |
SYMOPT_UNDNAME |
SYMOPT_LOAD_LINES);
if (SymInitialize(GetCurrentProcess(), NULL, TRUE)) {
init_error_ = ERROR_SUCCESS;
} else {
__debugbreak();
init_error_ = GetLastError();
}
}
DWORD init_error_;
//Lock lock_;
DISALLOW_COPY_AND_ASSIGN(SymbolContext);
};
} // namespace
#define ENABLE_STACK_TRACE 0
StackTrace::StackTrace() {
// From http://msdn.microsoft.com/en-us/library/bb204633(VS.85).aspx,
// the sum of FramesToSkip and FramesToCapture must be less than 63,
// so set it to 62.
const int kMaxCallers = 62;
// TODO(ajwong): Migrate this to StackWalk64.
#if ENABLE_STACK_TRACE
// WANNE: This only works with Visual Studio version >= 2008
#if _MSC_VER >= 1500
void* callers[kMaxCallers];
int count = CaptureStackBackTrace(0, kMaxCallers, callers, NULL);
// Not used, because we use CaptureStackBackTrace()
//int count = RtlCaptureStackBackTrace(0, kMaxCallers, callers, NULL);
if (count > 0) {
trace_.resize(count);
memcpy(&trace_[0], callers, sizeof(callers[0]) * count);
}
else
{
trace_.resize(0);
}
#endif
#endif
}
static struct StackTraceLog {
sgp::Logger_ID id;
StackTraceLog() {
id = sgp::Logger::instance().createLogger();
sgp::Logger::instance().connectFile(id, L"stack_trace.log", false, sgp::Logger::FLUSH_ON_ENDL);
};
} s_log;
void StackTrace::PrintBacktrace(const char* msg) {
sgp::Logger::LogInstance log = SGP_LOG(s_log.id);
OutputToStream(msg, &log);
}
// Called first-chance from the vectored crash handler, so it runs *inside* the
// faulting thread with a possibly-wrecked heap: the very crash we want to report
// is often heap corruption (a trashed std::map, a wild pointer). Anything that
// allocates — the game Logger, std::vector, DbgHelp's Sym* — would fault again
// and take the report down with it. So this path is deliberately heap-free: only
// stack buffers and raw Win32. It emits runtime addresses plus the module table
// needed to make sense of them; symbolize offline against the build's PDB:
// symbolize_crash crash_report_001.txt JA2.exe
namespace sgp {
// Stamped into every crash report so a report maps to the exact build's PDB.
// Copied into a fixed buffer (no heap) — safe to read from a crash handler.
static char s_buildId[64] = { 0 };
void setCrashBuildId(const char* id) {
if (id) lstrcpynA(s_buildId, id, sizeof(s_buildId));
}
// Filled in once a report has been written; see crashReportMessage().
static WCHAR s_crashMessage[512] = { 0 };
const wchar_t* crashReportMessage() {
return s_crashMessage[0] ? s_crashMessage : NULL;
}
// The player's optional handle, for tying a report to whoever raises it with us.
// Sanitized here rather than at crash time: it is user input that lands in a text
// report the telemetry server parses line by line, so drop anything that could
// forge a line (CR/LF, control and non-ASCII characters) and cap the length.
static char s_userHandle[33] = { 0 };
void setCrashUserHandle(const wchar_t* handle) {
size_t out = 0;
for (size_t i = 0; handle && handle[i] && out < sizeof(s_userHandle) - 1; ++i) {
if (handle[i] >= L' ' && handle[i] <= L'~')
s_userHandle[out++] = (char)handle[i];
}
s_userHandle[out] = 0;
}
void writeExceptionBacktrace(_EXCEPTION_POINTERS* ep) {
if (ep == NULL || ep->ContextRecord == NULL || ep->ExceptionRecord == NULL)
return;
// The same fault storms (Wine re-dispatches the crashing window message) and
// walking a wrecked stack can fault us in turn. Dump each distinct faulting
// address once, never re-enter. ponytail: single globals, fine in a crash.
static void* s_lastFault = NULL;
static bool s_inDump = false;
void* fault = ep->ExceptionRecord->ExceptionAddress;
if (s_inDump || fault == s_lastFault)
return;
s_lastFault = fault;
s_inDump = true;
// One fresh, numbered file per crash. CREATE_NEW claims the first free number,
// so reports never overwrite each other and pile up while a player is offline;
// the telemetry uploader drains and deletes them when it can reach the server.
char name[32];
HANDLE h = INVALID_HANDLE_VALUE;
for (int n = 1; n <= 999; ++n) {
wsprintfA(name, "crash_report_%03d.txt", n);
h = CreateFileA(name, GENERIC_WRITE, FILE_SHARE_READ, NULL,
CREATE_NEW, FILE_ATTRIBUTE_NORMAL, NULL);
if (h != INVALID_HANDLE_VALUE) break;
if (GetLastError() != ERROR_FILE_EXISTS) break; // real error, stop trying
}
if (h == INVALID_HANDLE_VALUE) { s_inDump = false; return; }
char line[192];
auto emit = [&](int n) { DWORD w; WriteFile(h, line, n, &w, NULL); };
const CONTEXT& c = *ep->ContextRecord;
const EXCEPTION_RECORD& r = *ep->ExceptionRecord;
emit(wsprintfA(line,
"\r\n*** CRASH code=%08lX eip=%08lX esp=%08lX ebp=%08lX ***\r\n",
r.ExceptionCode, c.Eip, c.Esp, c.Ebp));
// UTC, so a report stays unambiguous once it leaves the machine that wrote it.
SYSTEMTIME t;
GetSystemTime(&t);
emit(wsprintfA(line, " time %04d-%02d-%02d %02d:%02d:%02d UTC\r\n",
t.wYear, t.wMonth, t.wDay, t.wHour, t.wMinute, t.wSecond));
if (s_buildId[0])
emit(wsprintfA(line, " build %s\r\n", s_buildId));
if (s_userHandle[0])
emit(wsprintfA(line, " handle %s\r\n", s_userHandle));
if (r.ExceptionCode == EXCEPTION_ACCESS_VIOLATION && r.NumberParameters >= 2)
emit(wsprintfA(line, " access violation: %s %08lX\r\n",
r.ExceptionInformation[0] == 1 ? "write to " :
r.ExceptionInformation[0] == 8 ? "execute at" : "read from",
(DWORD)r.ExceptionInformation[1]));
// Where the loader actually put each image. Our executables are /DYNAMICBASE,
// so a runtime address matches neither the preferred base recorded in the PDB
// nor anything identifiable in a sibling module: without this table none of
// the addresses below can be symbolized. Walked off the PEB loader list, which
// costs no allocation, unlike EnumProcessModules or DbgHelp's module APIs.
emit(wsprintfA(line, " modules (base size name):\r\n"));
PEB_LDR_DATA* ldr = NtCurrentTeb()->ProcessEnvironmentBlock->Ldr;
LIST_ENTRY* head = &ldr->InMemoryOrderModuleList;
int seen = 0;
for (LIST_ENTRY* e = head->Flink; e != head && ++seen <= 128; e = e->Flink) {
LDR_DATA_TABLE_ENTRY* m =
CONTAINING_RECORD(e, LDR_DATA_TABLE_ENTRY, InMemoryOrderLinks);
DWORD base = (DWORD)(DWORD_PTR)m->DllBase;
IMAGE_DOS_HEADER* dos = (IMAGE_DOS_HEADER*)base;
if (!base || dos->e_magic != IMAGE_DOS_SIGNATURE)
continue;
IMAGE_NT_HEADERS* nt = (IMAGE_NT_HEADERS*)(base + dos->e_lfanew);
if (nt->Signature != IMAGE_NT_SIGNATURE)
continue;
// File name only, never the directory: a full path carries the player's
// Windows account name and whatever else their install path says about
// them, and the report leaves the machine. Symbolizing matches on module
// name and base, so the directory was never read by anything.
//
// Copied into a terminated buffer: FullDllName is counted, not terminated,
// and wsprintf supports neither "*" precision nor a way to bound %S, so a
// long name would run off the end of both.
const WCHAR* full = m->FullDllName.Buffer;
int fullChars = (int)(m->FullDllName.Length / sizeof(WCHAR));
if (!full || fullChars <= 0)
continue;
int start = 0;
for (int i = 0; i < fullChars; ++i)
if (full[i] == L'\\' || full[i] == L'/')
start = i + 1;
WCHAR modname[64];
int nameChars = fullChars - start + 1;
lstrcpynW(modname, full + start,
nameChars < ARRAYSIZE(modname) ? nameChars : ARRAYSIZE(modname));
emit(wsprintfA(line, " %08lX %08lX %S\r\n", base,
nt->OptionalHeader.SizeOfImage, modname));
}
// Committed stack bounds from the TEB, so a bad ebp can't fault our reads.
NT_TIB* tib = (NT_TIB*)NtCurrentTeb();
DWORD stkLo = (DWORD)(DWORD_PTR)tib->StackLimit;
DWORD stkHi = (DWORD)(DWORD_PTR)tib->StackBase;
emit(wsprintfA(line, " [0] %08lX\r\n", c.Eip)); // exact crash site
DWORD ebp = c.Ebp;
for (int i = 1; i < 64; ++i) {
if (ebp < stkLo || ebp + 8 > stkHi || (ebp & 3)) break;
DWORD ret = *(DWORD*)(ebp + 4);
DWORD next = *(DWORD*)ebp;
// Print every return address, not just our own module's: a fault inside
// ddraw/fmod/bink is exactly the case worth seeing, and the module table
// above already tells the reader which addresses land in real code.
emit(wsprintfA(line, " [%d] %08lX\r\n", i, ret));
if (next <= ebp) break; // frames must climb the stack
ebp = next;
}
FlushFileBuffers(h);
CloseHandle(h);
// Compose what the player gets told, while the fault details and the report's
// name are still in hand — but do not show it here. First-chance means the
// exception may yet be handled downstream, and a message box pumps messages,
// which on the wrecked heap that just faulted is a second crash. SGPExit puts
// it on screen once the game is actually going down.
WCHAR dir[MAX_PATH];
DWORD dirLen = GetCurrentDirectoryW(ARRAYSIZE(dir), dir);
if (dirLen == 0 || dirLen >= ARRAYSIZE(dir))
dir[0] = 0;
wsprintfW(s_crashMessage,
L"Jagged Alliance 2 1.13 crashed: exception %08lX at %08lX.\r\n\r\n"
L"A crash report was written to\r\n\r\n %s\\%S\r\n\r\n"
L"Please attach that file to your bug report.",
r.ExceptionCode, (DWORD)(DWORD_PTR)fault, dir, name);
s_inDump = false;
}
} // namespace sgp
void StackTrace::OutputToStream(const char* msg, sgp::Logger::LogInstance* os) {
SymbolContext* context = SymbolContext::Get();
DWORD error = context->init_error();
if (error != ERROR_SUCCESS)
{
(*os) << "Error initializing symbols (" << error
<< "). Dumping unresolved backtrace:"
<< sgp::endl;
for (size_t i = 0; (i < trace_.size()); ++i)
{
(*os) << "\t" << trace_[i] << sgp::endl;
}
}
else
{
(*os) << L"Backtrace: " << (msg != NULL ? msg : "") << sgp::endl;
context->OutputTraceToStream(trace_, os);
}
}
#endif // _MSC_VER