1dot13/source
1
0
Fork 0
mirror of https://github.com/1dot13/source.git synced 2026-07-29 13:52:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

say what size the pixelation pattern compare reads

Browse Source 
The pattern compare in Blt16BPPBufferPixelateRectWithColor gives neither
operand a size: a memory reference with no register to take the width from,
against an untyped zero. MSVC picks a byte, which is right -- Pattern is
UINT8[8][8], and every other access to it in the block goes through al --
but the source never says so, and clang-cl refuses to guess.

Naming the size changes nothing. cl emits 80 3C 1E 00 before and after.
This commit is contained in:
Marco Antonio J. Costa
2026-07-23 19:29:55 -03:00
committed by majcosta
parent 8495af4b00
commit 2c6202334e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sgp/vobject_blitters.cpp
+1 -1
View File
@@ -9790,7 +9790,7 @@ BlitNewLine:
mov ecx, width
BlitLine:
cmp [esi+ebx], 0
cmp byte ptr [esi+ebx], 0 // Pattern is UINT8[8][8]
je BlitLine2
mov [edi], ax