1dot13/source
1
0
Fork 0
mirror of https://github.com/1dot13/source.git synced 2026-07-22 13:40:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix ubID underflow

Browse Source 
Fixes illegal memory access if we tried to find previous merc and our currently selected one has ubID == 0
This commit is contained in:
Asdow
2025-11-19 10:12:53 +02:00
parent 0bbb01ae87
commit f902b01497
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Tactical/Overhead.cpp
+7 -1
View File
@@ -4896,7 +4896,13 @@ SoldierID FindPrevActiveAndAliveMerc( SOLDIERTYPE *pSoldier, BOOLEAN fGoodForLes
SoldierID bLastTeamID = gTacticalStatus.Team[ pSoldier->bTeam ].bFirstID;
SoldierID cnt = pSoldier->ubID - 1;
for ( ; cnt > bLastTeamID; --cnt )
// Guard against ubID underflow. We'll start searching for previous merc from the lastID in that case
if ( cnt >= NOBODY )
{
cnt = gTacticalStatus.Team[pSoldier->bTeam].bLastID;
}
for ( ; cnt >= bLastTeamID; --cnt )
{
pTeamSoldier = cnt;
if ( fOnlyRegularMercs )