00fb898600
Delete builddefines.h
...
Nothing was left in it but the include of profiler.h, and 132 translation units
were including it for that alone. Fifteen files were leaning on profiler.h to
drag in <set>, <vector> and <ostream> for them; those now include what they use.
This is the commit that moves line numbers. Removing an include line shifts
__LINE__ by one for everything below it, and __LINE__ is an immediate operand in
every Assert() and DebugMsg() call, so the four game executables differ from
their predecessors by roughly a thousand 32-bit constants each. Every one of
those is accounted for: each is a single immediate that moved by -1 where the
builddefines.h include went away, or +1 where a <set>/<vector> include was
added. Nothing else in .text, .rdata or .data moves, no object file's section
sizes change, and symbolize_crash and Ja2Export stay bit-identical.
The one non-immediate difference is that the 24 Editor translation units of the
non-editor apps stop emitting __Avx2WmemEnabledWeakValue, a 4-byte weak COMDAT
they only ever instantiated through profiler.h's <vector>. It is a UCRT weak
default that other translation units still provide.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com >
2026-08-22 01:07:26 -03:00
Asdow
6a8a22aba2
Move iter->exists() check to first
2026-06-12 15:52:24 +03:00
Asdow
4fcf03d31a
Include cleanup Tactical/.*cpp
2025-12-09 00:35:18 +02:00
Marco Antonio J. Costa and majcosta
1088ffc5b2
prevent shopkeeper interface from adding a second $
2025-10-08 05:36:37 -03:00
Marco Antonio J. Costa and majcosta
3d29eff4d8
use FormatMoney everywhere
2025-10-08 05:36:37 -03:00
Asdow
fb34eb6776
Use SoldierID for checks
2025-09-28 00:34:07 +03:00
Asdow
f3b99edbff
Fix Debug build
2025-09-24 19:21:58 +03:00
Asdow
82aca548f5
Merge branch 'master' into ExtraMercs
2025-09-24 16:14:10 +03:00
BeatAroundTheBuscher and GitHub
ed00830202
Fixes Upper/Lower Casing for include paths ( #487 )
...
* Fixing upper/lower case for includes
types.h, zconf.h and zlib.h were renamed so that global includes like Types.h
are not used.
2025-08-16 22:01:12 -03:00
Asdow
bfb724eab9
Use SoldierID
2024-12-01 18:23:52 +02:00
Asdow
24656f2810
Use SoldierID
2024-11-30 15:20:18 +02:00
Asdow
0d97e36c34
Use SoldierID
2024-11-21 23:56:44 +02:00
Asdow
cebd20f5d0
Update ShopKeeper Interface.cpp
2024-11-20 00:47:51 +02:00
Asdow
9532fbfe2c
Convert to SoldierID
2024-11-17 19:41:34 +02:00
Asdow
34f0b40f93
Convert functions and globals to SoldierID
2024-11-17 14:53:52 +02:00
Asdow
b98732daa7
Convert gusSelectedSoldier to SoldierID
2024-11-15 19:06:34 +02:00
Asdow
10250dc035
Merge branch 'master' into ExtraMercs
2024-11-09 13:44:53 +02:00
Asdow and GitHub
49a119e6b9
Convert INVTYPE boolean fields to flagmask ( #325 )
...
Rearranged fields from largest to smallest to remove alignment padding
2024-08-22 08:48:29 +03:00
kitty624
c03bd3ff3a
Update ShopKeeper Interface.cpp
...
reworking r9343
- already decided in IsItemlegal
- if it ain't legal, it won't be shown in ShopKeeperInventory, no need to bother with it again
2024-04-15 01:17:18 +02:00
Asdow and GitHub
b8a870df02
Reduce code duplication ( #233 )
...
* Use ConvertGridNoToCenterCellXY instead of CenterX & CenterY
* Add direction utility function
We have a lot of places in the code that calculate direction based on center cell coordinates, but lack a utility function for it similar to other direction methods.
* Use utility function for calculating direction
* Use ConvertGridNoToCenterCellXY
* Use utility function for direction
* Use ConvertGridNoToCenterCellXY instead of CenterX & CenterY
* Use ConvertGridNoToCenterCellXY instead of CenterX & CenterY
* Remove CenterX & CenterY functions
Use ConvertGridNoToCenterCellXY instead
* Remove CenterX & CenterY calls from UB configuration
* Address review feedback
* Remove duplicate function
ConvertGridNoToCenterCellXY and ConvertMapPosToWorldTileCenter do the exact same thing
* Use PythSpacesAway instead of GetRangeFromGridNoDiff
Both functions calculate the same thing
* Remove GetRangeFromGridNoDiff
* Remove calls to abs()
The values end up being squared anyways making these unnecessary
2023-10-07 15:14:15 +03:00
Asdow
03482ffc3d
Merge branch 'master' into ExtraMercs
2023-07-26 13:17:49 +03:00
majcosta and GitHub
24425a82b1
More unused stuff removal ( #49 )
...
* More unused stuff removal
delete:
- giant 'metaheaders' (JA2 All.h, Laptop All.h, etc), preferring to add #includes directly where needed
- unused ExceptionHandling and DbMan translation units
- unused WizShare.h, Bitmap.h, trle.h, video_private.h headers
* remove mentions from vc proj files too
* remove preprocessor conditionals for unused definitions
find . -iname '*.h' -o -iname '*.cpp' -exec unifdef.exe -m -UPRECOMPILED_HEADERS -UJA2_PRECOMPILED_HEADERS -UWIZ8_PRECOMPILED_HEADERS -UPRECOMPILEDHEADERS {} ';'
then manually fixed a couple files the tool errored out on
* yes, the comments too
as title
2023-01-03 15:51:48 +02:00
Asdow
1f0a8f46e8
Import changes from the local SVN working copy
2022-10-10 10:08:44 +03:00
rftr
746d15a1ba
remove magic numbers from the usLimitedToSystem bitflag
...
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@9355 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2022-04-02 01:11:25 +00:00
Shadooow
033ae4a191
Added two new tags into Items.xml, <FoodSystemExclusive> and <DiseaseSystemExclusive> which prevents specific items to appear without these systems enabled.
...
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@9343 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2022-03-24 05:40:46 +00:00
Flugente
3864aca117
Display item names in merchant inventory (by bfant)
...
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8844 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2020-07-05 12:48:12 +00:00
Flugente
f1bd0f8e8e
Fix: crash if player offer area exceeds 255 fields (possible on high resolutions)
...
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8823 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2020-06-17 22:24:52 +00:00
Sevenfm
8b53d273f9
New tags in CivGroupNames.xml: Side, CustomSide allow setting custom side for civilian group.
...
NewEye: fix possible bug.
InitShopKeeperSubTitledText: correctly initialize data.
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8764 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2020-02-27 10:51:45 +00:00
Sevenfm
8e9f9cb8a1
LOBOT code (by Asdow, original code by Bio).
...
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8755 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2020-02-15 16:19:35 +00:00
Flugente
0ab562c29e
- Added new additional dialogue events for commenting upon other merc's skill/kills, comment during bandaging
...
For more info, see http://thepit.ja-galaxy-forum.com/index.php?t=msg&th=23604&goto=356522&#msg_356522
- renamed dialogue enum for clarity
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8648 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2019-01-21 19:39:07 +00:00
Flugente
494dbc6e69
Store the profile type in the profile structure and remove superfluous code
...
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8620 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2018-09-24 19:36:28 +00:00
Flugente
2dbacd32de
The following options have been moved from the campaign the campaign start screen to JA2_Options.ini:
...
- Maximum number of IMPs (now MAX_IMP_CHARACTERS (Default: 10))
- Enemies drop all items (now DROP_ALL (Default: FALSE))
- Merc Story Backgrounds (now BACKGROUNDS (Default: TRUE))
- Food System (now FOOD (Default: FALSE))
- Improved Interrupt System (now IMPROVED_INTERRUPT_SYSTEM (Default: TRUE))
- Inventory Manipulation Costs AP (now INVENTORY_MANIPULATION_COSTS_AP (Default: FALSE))
For more info, see http://thepit.ja-galaxy-forum.com/index.php?t=msg&th=23855&goto=354656&#msg_354656
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8610 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2018-09-02 15:14:01 +00:00
Flugente
e205697804
Fix: possible underflow in UB code
...
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8605 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2018-08-28 20:44:16 +00:00
Flugente
e55b480996
New feature: Getting and using intel allows for more spy-related roleplay.
...
For more info, see http://thepit.ja-galaxy-forum.com/index.php?t=msg&th=23643&goto=352475&#msg_352475
Requires GameDir >= r2401.
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8522 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2018-02-18 23:17:34 +00:00
Flugente
dd3129ac11
New feature: additional dialogue allows modders to play additional dialogue on man occasions, including reactions to other people speaking
...
For more info, see http://thepit.ja-galaxy-forum.com/index.php?t=tree&goto=351982&#msg_351982 and for a demonstration http://thepit.ja-galaxy-forum.com/index.php?t=tree&goto=351981&#msg_351981
Requires GameDir >= r2400
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8516 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2018-01-10 23:41:52 +00:00
Flugente
a8e62cc406
- To make it easier to search for dialogue and understand what a line is supposed to mean, changed a few dialogue enums.
...
- Merged IsMercOnTeam...(...) functions into one
- Fix: during hiring, AIM mercs only complained about their hated ones if these were already in the country, thus ignoring other mercs in transit
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8512 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2018-01-04 15:50:31 +00:00
Flugente
04ce05bdf3
fallback solution if no image is found
...
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8458 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2017-08-26 16:10:15 +00:00
Flugente
0da98cc687
Trade menu background is no longer generated by random noise, but by cutting out a section of a much bigger picture.
...
For more info, see http://thepit.ja-galaxy-forum.com/index.php?t=msg&th=23486&goto=350754&#msg_350754
Requires GameDir >= r2385
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8457 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2017-08-26 15:51:37 +00:00
Flugente
b044a3a24f
Trade menu background is now generated with the use of random noise.
...
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8444 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2017-08-09 20:28:56 +00:00
Flugente
dc5db5c06a
- If a shopkeeper is a non-NPC dealer, show their body in the shopkeeper interface
...
- Fix: unwanted items in shopkeeper screen not always crossed out correctly
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8392 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2017-03-06 19:11:20 +00:00
Flugente
f65f97a27a
New feature: the trade menu is now resolution dependent, as a result more items can be traded at the same time. Trader budget is now also displayed.
...
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8389 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2017-02-26 16:08:03 +00:00
Flugente
ec52ab30e5
When trading, mark items that the trader won't buy.
...
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8367 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2017-01-15 23:48:34 +00:00
Flugente
ae2656b975
Fix: negative price backgrounds don't work as intended
...
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8343 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2016-11-22 21:20:14 +00:00
silversurfer
372adc37b8
repair and dirt system change:
...
Dirt is now part of gun status. The original dirt system has been removed. For details see:
http://thepit.ja-galaxy-forum.com/index.php?t=msg&th=20198&goto=347370&#msg_347370
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8325 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2016-10-19 15:58:02 +00:00
Flugente
57ec4e7fa1
Due to erroneous code, the encyclopedia feature has been deactivated. for more info, see http://thepit.ja-galaxy-forum.com/index.php?t=msg&th=23090&goto=345928&#msg_345928
...
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8273 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2016-07-16 12:21:22 +00:00
Flugente
7bb401b1fb
New feature: We can now create non-profile-based merchants via lua.scripts.
...
Requires GameDir >= r2320.
For more info, see http://thepit.ja-galaxy-forum.com/index.php?t=msg&th=23061&goto=345526&#msg_345526
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8212 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2016-05-15 17:11:29 +00:00
silversurfer
0ff8256c40
Fix: When talking to a shopkeeper the game could crash with an assertion in Shopkeeper Interface.cpp line 990 because the temp vector wasn't initialized properly.
...
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@8000 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2015-11-03 12:34:31 +00:00
Flugente
b118cf07b7
Merged revision(s) 7254 from branches/ja2_source_official_2014:
...
Deleted TAIWANESE language versions.
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@7255 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2014-06-02 19:00:06 +00:00
Flugente
d6186aca15
Merged revision(s) 6826-6828 from branches/ja2_source_official_2014:
...
- Minor code improvements and cleanup
- Fix from r6775 is no longer necessary.
- Code improvement: Instead of calling inv.size() repeatedly, just call it once and remember that value
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@6829 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2014-01-26 12:18:43 +00:00
Wanne
e7bd32dad9
Reworked Encyclopedia (by Moa)
...
- Access Encyclopedia from laptop screen
- Encyclopedia can be enabled/disabled in the ja2_options.ini: ENCYCLOPEDIA
- more infos: http://www.bears-pit.com/board/ubbthreads.php/topics/327315/Re_Ingame_Encyclopaedia.html#Post327315
git-svn-id: https://ja2svn.mooo.com/source/ja2/trunk/GameSource/ja2_v1.13/Build@6550 3b4a5df2-a311-0410-b5c6-a8a6f20db521
2013-10-31 11:42:05 +00:00