1d6ff6be3c
STR8 is char*, so const STR8 is char* const: a const pointer to a mutable
string, which is not what any of these sixty parameters wanted. What they
wanted is const CHAR8*, a pointer to a string they will not write to, and
that is what all of them do.
Under the MSVC compatibility rules clang-cl applies, a string literal still
converts to char*, so most calls survive this mistake untouched. An expression
of type const char* does not, and Intro.cpp has thirteen of them:
inireader.ReadString("INTRO_BEGINNING", "INTRO_REBEL_CRDT",
no_defaults ? "" : "INTRO\\Rebel_cr");
The conditional is a const char*, not a literal, so it has nowhere to bind and
the call does not compile. The other two arguments are literals and are
accepted, which is why only the third one was ever reported.
The invariant: in these two files, every parameter spelled const STR8 becomes
const CHAR8*, and nothing else changes. No body assigns to one of them, so
none needed rewriting; STR8 input_buffer in the five-argument ReadString is
genuinely an output and keeps its type. Three commented-out lines still say
const STR8 and were left as they are.
Verification:
grep -n 'const[ \t]*STR8' Utils/INIReader.h Utils/INIReader.cpp
# three hits, all on lines beginning with //
git show HEAD -U0 | grep '^[+-][^+-]' |
sed -E 's/const[ \t]+(STR8|CHAR8\*)/const/g; s/^[+-]//' |
sort | uniq -c | awk '$1 % 2' # no output
ninja -C build parse # ReadString class gone: 45 -> 32 sites
ninja -C build -k 0 # Release, four applications, green
ninja -C build-debug -k 0 # Debug, four applications, green
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JA2 v1.13
Preamble
Jagged Alliance 2 v1.13 is a modification for the Jagged Alliance 2 game.
Original development was done through SVN, this however ended abruptly in 2022, to keep the development going the step to Github has been made.
Feel free to participate in the development!
For more information you can visit the following locations:
- The Bear's Pit Forum
- Jagged Alliance 2 v1.13 - Starter Documentation
- How to get: latest 1.13, 7609, feature-descriptions and more
- JA2 v1.13 pbworks wiki (outdated)
- The Bear's Pit Discord
In case of any issues, look at Reports or Participation
Downloads
Note
All-in-one releases come for different languages and include JA2 v1.13, the Map Editor and JA2 Unfinished Business.
Visit the releases page to download the latest all-in-one.
Installation
-
Install the original Jagged Alliance 2
-
Download the latest all-in-one release and copy its content to JA2 game directory. Overwrite when asked.
-
Modify ini settings if you like.
-
Play the game.
Some additional information on can be found in folder "docs" inside download.
If you face issues with higher resolutions, alt+tab not working, blackscreen, etc.,
run the "cnc-ddraw-config.exe" in game-folder and adjust settings to your liking.
(those issues can occur due to the combination of old game and modern OS/hardware, cnc-ddraw helps to avoid those)
Visual Studio setup
- Run
Visual Studio 2019or newer. - Clone and open the location with the source code using one of these two options:
- Click
Clone a repository- Enter
git@github.com:1dot13/source.gitorhttps://github.com/1dot13/source.gitin the Repository location field, select the path you want to clone the repository to and clickClone. - Double-click on
Folder Viewin theSolution Explorer
- Enter
- Click
Open a local folder- Use this option if you already cloned the repository yourself.
- Click
- Visual Studio will automatically detect the CMake configuration files and will run the CMake generation. There will bet a CMake error in the logs saying
No existing preset was found, copied a preset template to [some_path]. This is normal and only happens once. - Click on the dropdown that says
x64-Debugand selectManage configurations.... This should trigger Visual Studio to load theCMakeUserPresets.jsonfile it just copied. Now you can close the window for managing the configurations. - The
x64-Debugoption should have been replaced by1dot13 Debug. Click it and selectManage configurations...again. Here is where you configure the language for the built executables as well as which ones to build, Most important, here is where you setCMAKE_RUNTIME_OUTPUT_DIRECTORYto the path to your JA2 1.13 installation. This will be used for debugging. Note that the path needs to have a working 1.13 installation, and that includes the 1.13 game data. - You can use
Build -> Build Allto build the executables you selected in the configuration.
Reports
For more information and reports, visit Bug reports at Bear's Pit Forum or join the Bear's Pit Discord
Participation
Feel free to participate on GitHub. If you want to know how, or simply wanna share your thoughts on a topic join the Bear's Pit Discord