Marco Antonio J. Costaandmajcosta
b147e47856
DrawTextToScreen takes STR16, a mutable wchar_t*, for a string it only
measures and prints. Quest Debug System.cpp picks its text with a conditional:
DrawTextToScreen( gubFact[ usLoop1 ] ? L"True" : L"False", ... );
which has type const wchar_t*. clang-cl's MSVC compatibility lets a bare
string literal decay to wchar_t*, but not a const wchar_t* expression, so it
reports
error: no matching function for call to 'DrawTextToScreen'
note: candidate function not viable: 1st argument ('const wchar_t *')
would lose const qualifier
The parameter is const-correct in every function DrawTextToScreen hands the
string on to, so the change follows the string down the call chain rather
than stopping at the top:
DrawTextToScreen, ShadowText Utils/WordWrap.h
WFStringPixLength Utils/Font Control.h
mprintf, StringPixLength, sgp/Font.h
VarFindFontCenterCoordinates,
VarFindFontRightCoordinates
WinFontStringPixLength sgp/WinFont.h
gprintfdirty TileEngine/Render Dirty.h
The varargs members of that list copy the format string into a local buffer
before doing anything with it, and the measuring ones walk it and return a
width; none of the nine assigns through the parameter. Where StringPixLength
casts the string to UINT16* to walk it, the cast and the local now carry the
const rather than dropping it.
Callers are unaffected: every one already passes something that converts to
const CHAR16*. Both configurations build with no new diagnostics, and the
parse sweep drops from 9 error sites in 7 files to 5 in 3.
To check the claim that nothing writes through these parameters, read the
nine bodies; each is short.
JA2 v1.13
Preamble
Jagged Alliance 2 v1.13 is a modification for the Jagged Alliance 2 game.
Original development was done through SVN, this however ended abruptly in 2022, to keep the development going the step to Github has been made.
Feel free to participate in the development!
For more information you can visit the following locations:
- The Bear's Pit Forum
- Jagged Alliance 2 v1.13 - Starter Documentation
- How to get: latest 1.13, 7609, feature-descriptions and more
- JA2 v1.13 pbworks wiki (outdated)
- The Bear's Pit Discord
In case of any issues, look at Reports or Participation
Downloads
Note
All-in-one releases come for different languages and include JA2 v1.13, the Map Editor and JA2 Unfinished Business.
Visit the releases page to download the latest all-in-one.
Installation
-
Install the original Jagged Alliance 2
-
Download the latest all-in-one release and copy its content to JA2 game directory. Overwrite when asked.
-
Modify ini settings if you like.
-
Play the game.
Some additional information on can be found in folder "docs" inside download.
If you face issues with higher resolutions, alt+tab not working, blackscreen, etc.,
run the "cnc-ddraw-config.exe" in game-folder and adjust settings to your liking.
(those issues can occur due to the combination of old game and modern OS/hardware, cnc-ddraw helps to avoid those)
Visual Studio setup
- Run
Visual Studio 2019or newer. - Clone and open the location with the source code using one of these two options:
- Click
Clone a repository- Enter
git@github.com:1dot13/source.gitorhttps://github.com/1dot13/source.gitin the Repository location field, select the path you want to clone the repository to and clickClone. - Double-click on
Folder Viewin theSolution Explorer
- Enter
- Click
Open a local folder- Use this option if you already cloned the repository yourself.
- Click
- Visual Studio will automatically detect the CMake configuration files and will run the CMake generation. There will bet a CMake error in the logs saying
No existing preset was found, copied a preset template to [some_path]. This is normal and only happens once. - Click on the dropdown that says
x64-Debugand selectManage configurations.... This should trigger Visual Studio to load theCMakeUserPresets.jsonfile it just copied. Now you can close the window for managing the configurations. - The
x64-Debugoption should have been replaced by1dot13 Debug. Click it and selectManage configurations...again. Here is where you configure the language for the built executables as well as which ones to build, Most important, here is where you setCMAKE_RUNTIME_OUTPUT_DIRECTORYto the path to your JA2 1.13 installation. This will be used for debugging. Note that the path needs to have a working 1.13 installation, and that includes the 1.13 game data. - You can use
Build -> Build Allto build the executables you selected in the configuration.
Reports
For more information and reports, visit Bug reports at Bear's Pit Forum or join the Bear's Pit Discord
Participation
Feel free to participate on GitHub. If you want to know how, or simply wanna share your thoughts on a topic join the Bear's Pit Discord