Files
source/Tactical
70b11ee120 make narrowing conversions in braced initialisers explicit
A braced initialiser does not allow a narrowing conversion unless the value
is a constant expression the compiler can prove fits. Every site here holds a
runtime value: WORLD_COLS is the global guiWorldCols, the laptop screen
coordinates are built from iScreenWidthOffset, the sector limits come from the
externalised options. MSVC accepts all of it silently; clang rejects it, and
it is ill-formed.

Nothing about the generated code changes. MSVC was already performing these
conversions; the casts only say so out loud, at the 73 places where it was
happening implicitly.

The invariant: each site is wrapped in a static_cast to the element type the
initialiser already had, and nothing else is touched. No type is widened, no
expression is reassociated, no value is clamped or checked. static_cast rather
than a C-style cast so that a later reader can grep for the narrowings, and so
that none of these can quietly become a reinterpret_cast if a type changes.

Verification:

    # every changed line differs only by inserted casts and their parentheses
    git show HEAD -U0 | grep '^[+-][^+-]' |
      sed -E 's/static_cast<[A-Za-z0-9_]+>//g; s/[()]//g; s/^[+-]//' |
      sort | uniq -c | awk '$1 % 2'          # no output

    git show HEAD -U0 | grep -c '^+[^+]'     # 38 lines, 73 casts

    ninja -C build parse                     # narrowing class gone: 129 -> 91 sites
    ninja -C build -k 0                      # Release, four applications, green
    ninja -C build-debug -k 0                # Debug, four applications, green

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-23 19:29:55 -03:00
..
2026-05-28 16:33:48 +03:00
2025-12-09 00:35:18 +02:00
2025-11-19 21:11:19 +02:00
2025-12-09 00:35:18 +02:00
2026-01-03 17:27:43 +02:00
2025-12-09 00:35:18 +02:00
2025-06-22 12:43:33 +03:00
2025-12-09 00:35:18 +02:00
2026-02-21 21:00:38 +02:00
2026-01-03 17:27:43 +02:00
2025-12-09 00:35:18 +02:00
2025-09-24 16:14:10 +03:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2014-01-01 12:02:23 +00:00
2024-11-18 01:01:57 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-11-23 18:28:17 +02:00
2026-06-12 15:52:24 +03:00
2025-08-08 18:00:31 +03:00
2025-08-08 18:00:31 +03:00
2025-12-09 00:35:18 +02:00
2026-06-12 15:52:24 +03:00
2025-12-09 00:35:18 +02:00
2024-11-17 23:45:48 +02:00
2026-01-03 17:27:43 +02:00
2024-11-17 23:45:48 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2026-06-01 21:45:55 -03:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2024-11-17 19:41:34 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-08-08 16:39:52 +03:00
2025-08-08 18:00:31 +03:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2024-11-17 22:29:31 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2023-01-03 15:51:48 +02:00
2023-01-03 15:51:48 +02:00