Files
source/Tactical
1bf28bc07a ask whether strstr found the tag, not whether it is positive
strstr returns a pointer into the string or NULL, and these four tests compare
that pointer to 0 with >. Ordering a pointer against a null pointer constant
is not something C++ defines; MSVC allows it, clang rejects it.

The intent is plainly "did this attribute name contain the tag", and the
result is the same either way, since the only pointer these can produce that
is not greater than zero is the null one. != NULL says it directly, and reads
like the strcmp(name, "...") == 0 tests it sits between.

strstr rather than strcmp is deliberate here: the attributes it looks for are
numbered, usAttachment1 through usAttachment4 and usResult1 upwards, so an
exact comparison would not match them. That is unchanged.

Verification:

    grep -rn 'strstr([^)]*)[ \t]*[><]' --include=*.cpp --include=*.h .   # nothing
    ninja -C build parse         # pointer-ordering class gone: 32 -> 28 sites
    ninja -C build -k 0          # Release, four applications, green
    ninja -C build-debug -k 0    # Debug, four applications, green

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-23 19:29:55 -03:00
..
2026-05-28 16:33:48 +03:00
2025-12-09 00:35:18 +02:00
2025-11-19 21:11:19 +02:00
2025-12-09 00:35:18 +02:00
2026-01-03 17:27:43 +02:00
2025-12-09 00:35:18 +02:00
2025-06-22 12:43:33 +03:00
2025-12-09 00:35:18 +02:00
2026-02-21 21:00:38 +02:00
2026-01-03 17:27:43 +02:00
2025-12-09 00:35:18 +02:00
2025-09-24 16:14:10 +03:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2014-01-01 12:02:23 +00:00
2024-11-18 01:01:57 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-11-23 18:28:17 +02:00
2026-06-12 15:52:24 +03:00
2025-08-08 18:00:31 +03:00
2025-08-08 18:00:31 +03:00
2025-12-09 00:35:18 +02:00
2026-06-12 15:52:24 +03:00
2025-12-09 00:35:18 +02:00
2024-11-17 23:45:48 +02:00
2026-01-03 17:27:43 +02:00
2024-11-17 23:45:48 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2026-06-01 21:45:55 -03:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2024-11-17 19:41:34 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-08-08 16:39:52 +03:00
2025-08-08 18:00:31 +03:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2024-11-17 22:29:31 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2025-12-09 00:35:18 +02:00
2023-01-03 15:51:48 +02:00
2023-01-03 15:51:48 +02:00