1dot13/source
1
0
Fork 0
mirror of https://github.com/1dot13/source.git synced 2026-07-29 13:52:17 +02:00
Code Issues Packages Projects Releases Wiki Activity
Files
3db2d60a4de9865f4ecd1e857dbf6c55a72169fd
source/Laptop
T
History
Marco Antonio J. CostamajcostaClaude Opus 4.8
 b5ea70aa44 declare the postal service iterators as values, not as references 
PostalService.h names every type twice, once plainly and once as a reference:
RefToDestinationStruct is DestinationStruct&, RefToShipmentList is
ShipmentList&. That scheme was extended to the iterators, and there it does
not work. Every one of the seventeen uses looks like this:

    RefToShipmentListIterator sli = _Shipments.begin();

begin() returns a value, so this binds a non-const reference to a temporary.
MSVC allows it as an extension; the temporary still dies at the end of the
full expression, which leaves sli referring to a dead object for the whole
rest of the function. It works only because nothing has reused the stack slot
yet. clang rejects it outright.

Iterators are already handles into their container, so a reference to one buys
nothing: the plain typedef says exactly what these seventeen variables want to
be. DESTINATION and SHIPMENT now take theirs by value, which changes nothing
for either, as both only dereference the iterator they are given.

Two of the reference typedefs, RefToDestinationDeliveryInfoTableIterator and
RefToDeliveryCallbackDataListIterator, had no uses at all. They are removed
rather than left behind, since their only possible use is the pattern this
commit removes.

Verification:

    grep -rn 'RefTo[A-Za-z]*Iterator' --include=*.cpp --include=*.h .   # nothing
    ninja -C build parse         # bind-to-temporary class gone: 91 -> 60 sites
    ninja -C build -k 0          # Release, four applications, green
    ninja -C build-debug -k 0    # Debug, four applications, green

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-23 19:29:55 -03:00
..
aim.cpp
include cleanup
2025-12-03 23:52:05 +02:00
aim.h
Fixes (by Moa)
2013-10-19 12:47:53 +00:00
AimArchives.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
AimArchives.h
*** MERGED source code from development trunk revision 4890 up to latest current revision 5105 ***
2012-03-23 18:46:54 +00:00
AimFacialIndex.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
AimFacialIndex.h
************************************************************
2011-01-18 09:11:09 +00:00
AimHistory.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
AimHistory.h
Original Source for 1.13 Mod High Resolution version from 12/06/05
2006-04-19 11:32:51 +00:00
AimLinks.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
AimLinks.h
Original Source for 1.13 Mod High Resolution version from 12/06/05
2006-04-19 11:32:51 +00:00
AimMembers.cpp
Strip dead per-language .slf entries from gGameLibaries
2026-07-21 09:46:41 -03:00
AimMembers.h
remove DrawMoneyOnScreen
2025-09-26 02:31:02 -03:00
AimPolicies.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
AimPolicies.h
Original Source for 1.13 Mod High Resolution version from 12/06/05
2006-04-19 11:32:51 +00:00
AimSort.cpp
make narrowing conversions in braced initialisers explicit
2026-07-23 19:29:55 -03:00
AimSort.h
Features (by Buggler)
2012-10-21 16:10:49 +00:00
BaseTable.cpp
Set table mouse_region priorities lower than bookmark bar
2024-12-30 21:21:30 +02:00
BaseTable.h
Improvements for BaseTable:
2020-05-17 14:13:57 +00:00
BobbyR.cpp
declare the postal service iterators as values, not as references
2026-07-23 19:29:55 -03:00
BobbyR.h
CHINESE: actually display BobbyR amount purchased correctly at runtime (#398)
2025-01-03 21:03:09 -03:00
BobbyRAmmo.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
BobbyRAmmo.h
Original Source for 1.13 Mod High Resolution version from 12/06/05
2006-04-19 11:32:51 +00:00
BobbyRArmour.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
BobbyRArmour.h
Original Source for 1.13 Mod High Resolution version from 12/06/05
2006-04-19 11:32:51 +00:00
BobbyRGuns.cpp
use FormatMoney everywhere
2025-10-08 05:36:37 -03:00
BobbyRGuns.h
New Misc filter buttons for Bobby Rays, by attachmentClass:
2012-05-18 04:36:52 +00:00
BobbyRMailOrder.cpp
use FormatMoney everywhere
2025-10-08 05:36:37 -03:00
BobbyRMailOrder.h
*** MERGED source code from development trunk revision 4890 up to latest current revision 5105 ***
2012-03-23 18:46:54 +00:00
BobbyRMisc.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
BobbyRMisc.h
Original Source for 1.13 Mod High Resolution version from 12/06/05
2006-04-19 11:32:51 +00:00
BobbyRShipments.cpp
declare the postal service iterators as values, not as references
2026-07-23 19:29:55 -03:00
BobbyRShipments.h
Original Source for 1.13 Mod High Resolution version from 12/06/05
2006-04-19 11:32:51 +00:00
BobbyRUsed.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
BobbyRUsed.h
Original Source for 1.13 Mod High Resolution version from 12/06/05
2006-04-19 11:32:51 +00:00
BriefingRoom_Data.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
BriefingRoom_Data.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
BriefingRoom.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
BriefingRoom.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
BriefingRoomM.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
BriefingRoomM.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
BrokenLink.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
BrokenLink.h
Original Source for 1.13 Mod High Resolution version from 12/06/05
2006-04-19 11:32:51 +00:00
CampaignHistory_Summary.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
CampaignHistory_Summary.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
CampaignHistoryData.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
CampaignHistoryMain.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
CampaignHistoryMain.h
New feature: Diseaes affect your mercenaries. They can be contracted in varíous ways and have varying effects.
2014-08-10 13:45:11 +00:00
CampaignStats.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
CampaignStats.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
CharProfile.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
CharProfile.h
Make LANGUAGE switchable in runtime (#653)
2026-07-21 05:33:03 -03:00
CMakeLists.txt
Add a CMake build
2023-01-14 02:08:39 -03:00
DropDown.cpp
Fix: compiler warnings
2020-05-30 14:26:16 +00:00
DropDown.h
New feature (by rftr): Arulco Rebel Command (ARC)
2021-08-22 19:00:09 +00:00
DynamicDialogueWidget.cpp
Fix: compiler warnings
2020-05-30 14:26:16 +00:00
DynamicDialogueWidget.h
Changed variables to UINT16, in case a dropdown has a lot of entries
2016-05-01 19:04:50 +00:00
email.cpp
Remove magic numbers
2026-01-04 14:57:55 +02:00
email.h
Remove magic numbers
2026-01-04 14:57:55 +02:00
Encyclopedia_Data_new.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
Encyclopedia_Data_new.h
Due to erroneous code, the encyclopedia feature has been deactivated. for more info, see http://thepit.ja-galaxy-forum.com/index.php?t=msg&th=23090&goto=345928&#msg_345928
2016-07-16 12:21:22 +00:00
Encyclopedia_new.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
Encyclopedia_new.h
Due to erroneous code, the encyclopedia feature has been deactivated. for more info, see http://thepit.ja-galaxy-forum.com/index.php?t=msg&th=23090&goto=345928&#msg_345928
2016-07-16 12:21:22 +00:00
FacilityProduction.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
FacilityProduction.h
New feature: factories allows facilities to create items
2020-05-17 20:52:27 +00:00
files.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
files.h
Additional Laptop files (by sun_alf).
2022-04-13 10:43:49 +00:00
finances.cpp
remove now unused functions
2025-10-08 05:36:37 -03:00
finances.h
remove now unused functions
2025-10-08 05:36:37 -03:00
florist Cards.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
florist Cards.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
florist Gallery.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
florist Gallery.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
florist Order Form.cpp
declare the postal service iterators as values, not as references
2026-07-23 19:29:55 -03:00
florist Order Form.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
florist.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
florist.h
Original Source for 1.13 Mod High Resolution version from 12/06/05
2006-04-19 11:32:51 +00:00
funeral.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
funeral.h
Original Source for 1.13 Mod High Resolution version from 12/06/05
2006-04-19 11:32:51 +00:00
GunEmporium.cpp
Original Source for 1.13 Mod High Resolution version from 12/06/05
2006-04-19 11:32:51 +00:00
GunEmporium.h
Original Source for 1.13 Mod High Resolution version from 12/06/05
2006-04-19 11:32:51 +00:00
history.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
history.h
New feature: transport groups (#172)
2023-07-04 20:58:56 -07:00
IMP AboutUs.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP AboutUs.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
IMP Attribute Entrance.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Attribute Entrance.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
IMP Attribute Finish.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Attribute Finish.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
IMP Attribute Selection.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Attribute Selection.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
IMP Background.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Background.h
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Begin Screen.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Begin Screen.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
IMP Character and Disability Entrance.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Character and Disability Entrance.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
IMP Character Trait.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Character Trait.h
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Color Choosing.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Color Choosing.h
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Compile Character.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Compile Character.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
IMP Confirm.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Confirm.h
Fix: if DYNAMIC_IMP_PROFILE_COST is TRUE, the IMP cost is too high(by sun_alf)
2020-06-30 20:23:25 +00:00
IMP Disability Trait.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Disability Trait.h
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Finish.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Finish.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
IMP Gear Entrance.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Gear Entrance.h
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Gear.cpp
Merge branch 'master' into ExtraMercs
2025-09-24 16:14:10 +03:00
IMP Gear.h
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP HomePage.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP HomePage.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
IMP MainPage.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP MainPage.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
IMP Minor Trait.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Minor Trait.h
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Personality Entrance.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Personality Entrance.h
Make LANGUAGE switchable in runtime (#653)
2026-07-21 05:33:03 -03:00
IMP Personality Finish.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Personality Finish.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
IMP Personality Quiz.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Personality Quiz.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
IMP Portraits.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Portraits.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
IMP Prejudice.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Prejudice.h
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Skill Trait.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Skill Trait.h
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Text System.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Text System.h
Make LANGUAGE switchable in runtime (#653)
2026-07-21 05:33:03 -03:00
IMP Voices.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMP Voices.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
IMPVideoObjects.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
IMPVideoObjects.h
Implemented new IMP gear selection interface to replace the dropdown menus. Requires GameDir rev 2652.
2022-08-01 21:15:34 +00:00
insurance Comments.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
insurance Comments.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
insurance Contract.cpp
Use externalized emails
2026-01-03 17:27:43 +02:00
insurance Contract.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
insurance Info.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
insurance Info.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
Insurance Text.h
Original Source for 1.13 Mod High Resolution version from 12/06/05
2006-04-19 11:32:51 +00:00
insurance.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
insurance.h
- New Feature: dynamic opinions allows mercs to form opinions about each other depening on actions they/the player take or do not take. These can be viewed in the 'MeLoDY 'website. See also http://www.bears-pit.com/board/ubbthreads.php/topics/333259.html#Post333259
2014-05-28 22:10:42 +00:00
Intelmarket.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
Intelmarket.h
Fix: missing files
2018-02-27 00:49:42 +00:00
laptop.cpp
Use externalized emails
2026-01-03 17:27:43 +02:00
laptop.h
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
LaptopSave.h
Update LaptopSave.h
2024-11-16 11:55:57 +02:00
merccompare.cpp
Merge branch 'master' into ExtraMercs
2025-09-24 16:14:10 +03:00
merccompare.h
New feature: Diseaes affect your mercenaries. They can be contracted in varíous ways and have varying effects.
2014-08-10 13:45:11 +00:00
mercs Account.cpp
use FormatMoney everywhere
2025-10-08 05:36:37 -03:00
mercs Account.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
mercs Files.cpp
use FormatMoney everywhere
2025-10-08 05:36:37 -03:00
mercs Files.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
mercs No Account.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
mercs No Account.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
mercs.cpp
Use externalized emails
2026-01-03 17:27:43 +02:00
mercs.h
- Improvement of M.E.R.C availability (by silversurfer)
2013-08-15 20:20:06 +00:00
MilitiaInterface.cpp
Fix: individual militia in impassable sectors cannot be dismissed via website
2020-07-04 14:47:40 +00:00
MilitiaInterface.h
New feature: individual militia creates small militia profiles that track a militia's history and allow it to be recreated, thereby maintaining the illusion of persistent militia.
2016-05-06 14:51:24 +00:00
MilitiaWebsite.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
MilitiaWebsite.h
New feature: individual militia creates small militia profiles that track a militia's history and allow it to be recreated, thereby maintaining the illusion of persistent militia.
2016-05-06 14:51:24 +00:00
personnel.cpp
use FormatMoney everywhere
2025-10-08 05:36:37 -03:00
personnel.h
remove unused TransferFundsFromBankToMerc/MercToBank
2025-10-08 03:07:23 -03:00
PMC.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
PMC.h
New Feature: a private military company allows hiring of advanced militia. For more info, see http://www.ja-galaxy-forum.com/ubbthreads.php/topics/335279#Post335279
2014-08-30 17:34:25 +00:00
PostalService.cpp
declare the postal service iterators as values, not as references
2026-07-23 19:29:55 -03:00
PostalService.h
declare the postal service iterators as values, not as references
2026-07-23 19:29:55 -03:00
sirtech.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
sirtech.h
Original Source for 1.13 Mod High Resolution version from 12/06/05
2006-04-19 11:32:51 +00:00
Speck Quotes.h
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
Store Inventory.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
Store Inventory.h
Original Source for 1.13 Mod High Resolution version from 12/06/05
2006-04-19 11:32:51 +00:00
WHO.cpp
Fixes Upper/Lower Casing for include paths (#487)
2025-08-16 22:01:12 -03:00
WHO.h
New feature: Diseaes affect your mercenaries. They can be contracted in varíous ways and have varying effects.
2014-08-10 13:45:11 +00:00
XML_AIMAvailability.cpp
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
XML_BriefingRoom.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
XML_CampaignStatsEvents.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
XML_ConditionsForMercAvailability.cpp
add newline at end of file where it's lacking
2024-12-14 19:05:48 -03:00
XML_DeliveryMethods.cpp
declare the postal service iterators as values, not as references
2026-07-23 19:29:55 -03:00
XML_Email.cpp
Use externalized emails
2026-01-03 17:27:43 +02:00
XML_EmailMercAvailable.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
XML_EmailMercLevelUp.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
XML_History.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
XML_IMPPortraits.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
XML_IMPVoices.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
XML_OldAIMArchive.cpp
More unused stuff removal (#49)
2023-01-03 15:51:48 +02:00
XML_ShippingDestinations.cpp
declare the postal service iterators as values, not as references
2026-07-23 19:29:55 -03:00